Alon Bar-Lev has posted comments on this change. Change subject: aaa: more fixes to command context propgation ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/29290/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java: Line 190: installVdsParameters, Line 191: cloneContext() Line 192: .withExecutionContext(installCtx) Line 193: .withoutLock() Line 194: .withoutCompensationContext()); so isn't this: detach.withExecutionContext(installCtx) ? Line 195: } Line 196: }); Line 197: ExecutionHandler.setAsyncJob(getExecutionContext(), true); Line 198: } http://gerrit.ovirt.org/#/c/29290/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 675: for (VdcActionParametersBase p : getParameters().getImagesParameters()) { Line 676: p.setTaskGroupSuccess(false); Line 677: Backend.getInstance().endAction(VdcActionType.CreateImageTemplate, Line 678: p, Line 679: cloneContext().withoutCompensationContext().withoutExecutionContext().withoutLock()); detach? Line 680: } Line 681: Line 682: // if template exist in db remove it Line 683: if (getVmTemplate() != null) { http://gerrit.ovirt.org/#/c/29290/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java: Line 6: import java.util.List; Line 7: import java.util.Map; Line 8: Line 9: import org.apache.commons.lang.StringUtils; Line 10: import org.ovirt.engine.core.bll.context.CommandContext; - Line 11: import org.ovirt.engine.core.bll.snapshots.SnapshotsValidator; Line 12: import org.ovirt.engine.core.bll.storage.StoragePoolValidator; Line 13: import org.ovirt.engine.core.bll.tasks.SPMAsyncTaskHandler; Line 14: import org.ovirt.engine.core.bll.tasks.TaskHandlerCommand; -- To view, visit http://gerrit.ovirt.org/29290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf9e0216c83d981d11bb2d8d2a939fd2a279d9d Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
