Moti Asayag has posted comments on this change. Change subject: aaa: more fixes to command context propgation ......................................................................
Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/29290/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java: Line 4 Line 5 Line 6 Line 7 Line 8 shouldn't it be removed from this patch ? http://gerrit.ovirt.org/#/c/29290/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java: Line 521: modifyContextForIntenrakJob s/modifyContextForIntenrakJob/modifyContextForIntenralJob would you mind reversing the order of the parameters ? as returnedContext cannot be null and the lock might be. Line 520: Line 521: private static CommandContext modifyContextForIntenrakJob(EngineLock lock, CommandContext returnedContext) { Line 522: ExecutionContext executionContext = new ExecutionContext(); Line 523: executionContext.setJobRequired(true); Line 524: executionContext.setMonitored(true); the three lines above can be extracted into a private method named "createdMonitoredExecutionContext()" or "createExecutedContextForMonitoring()" and inlined. Line 525: return returnedContext Line 526: .withExecutionContext(executionContext) Line 527: .withLock(lock) Line 528: .withoutCompensationContext(); -- To view, visit http://gerrit.ovirt.org/29290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf9e0216c83d981d11bb2d8d2a939fd2a279d9d Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
