Eli Mesika has posted comments on this change.

Change subject: core: new function to list vds' that have all required network 
(#826593)
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File backend/manager/dbscripts/vds_sp.sql
Line 710: create or replace function IsInArray(sm anyarray, big anyarray) 
returns boolean
There is a built in contains operator for that 
see
http://www.postgresql.org/docs/8.3/static/functions-array.html
apart from that please target any general functions to common_sp.sql and prefix 
its name with fn_db_

--
To view, visit http://gerrit.ovirt.org/5752
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8fad6b1bc71e4ab52e5095df17eb9725afc0827
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to