Moti Asayag has posted comments on this change.
Change subject: core: new function to list vds' that have all required network
(#826593)
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File backend/manager/dbscripts/vds_sp.sql
Line 753: array(SELECT distinct vmif.network_name from vm_interface
vmif join vm_static vm on vm.vm_guid = vmif.vm_guid where vmif.vm_guid =
v_vm_id),
I don't think there is a need for join with the vm_static as there is a cascade
for vm_interfaces depends on the vm_static:
Foreign-key constraints:
"fk_vm_interface_vm_static" FOREIGN KEY (vm_guid) REFERENCES
vm_static(vm_guid) ON DELETE CASCADE
However, the join could be useful to get the cluster-id and minimize the host
selection only for hosts from the same cluster.
....................................................
Commit Message
Line 7: core: new function to list vds' that have all required network (#826593)
please add the bug's url
--
To view, visit http://gerrit.ovirt.org/5752
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8fad6b1bc71e4ab52e5095df17eb9725afc0827
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
