Mike Kolesnik has posted comments on this change. Change subject: core: new function to list vds' that have all required network (#826593) ......................................................................
Patch Set 2: I would prefer that you didn't submit this I think it would be a mistake to hide business logic inside the DB queries. As you wrote in the commit message yourself, this is only part of the checks, so why wouldn't we put all checks in the DB? Because then it makes things very hard to debug & maintain, and if we would want to migrate to another DB implementation (ie not stored p[rocedured, but ORM or even a different DB vendor) it would probably complicate the change to translate business logic instead of simple queries. -- To view, visit http://gerrit.ovirt.org/5752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8fad6b1bc71e4ab52e5095df17eb9725afc0827 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
