Allon Mureinik has posted comments on this change. Change subject: core: added information to ConnectStorageVDScommand logs (#835546) ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStorageServerVDSCommandParameters.java Line 63: sb.append(con.getNfsTimeo()); Ayal - I agree that storage_server_connection should have some type awareness, but even without it - why should the printing logic be here and not just override storage_server_connections' toString() method? -- To view, visit http://gerrit.ovirt.org/5748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b613bd18ef9586040862cac56373705f3e65237 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
