Liron Aravot has posted comments on this change.
Change subject: core: added information to ConnectStorageVDScommand logs
(#835546)
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStorageServerVDSCommandParameters.java
Line 47: for (storage_server_connections con : getConnectionList()) {
the name is ugly, but it's part of convention of all of those classes. the
class is used from many places, i could use eclipse refactoring to rename is
automatically, but it might not be right to send at the moment such a big patch
and change only this class's name while the others left with this naming
convention..up to you :)
Line 63: sb.append(con.getNfsTimeo());
I think that the toString() method do need to return all fields without any
logic. this method is used for debugging purposes and for printing a simple
POJO as it is, so if we decide to print only few of the fields based on the
connection type and add some logic to it - we add opening for more bugs. if by
mistake any unrelated property would be set - we won't see it on the debugging
prints and would have to look for it ourselves in the flow to realize why we
got there.
--
To view, visit http://gerrit.ovirt.org/5748
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b613bd18ef9586040862cac56373705f3e65237
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
