Liron Aravot has posted comments on this change. Change subject: core: added information to ConnectStorageVDScommand logs (#835546) ......................................................................
Patch Set 4: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStorageServerVDSCommandParameters.java Line 48: sb.append(con.toString()); furthermore, i think that if we do have a chance for NPE there, we will reach it much sooner in the flow. -- To view, visit http://gerrit.ovirt.org/5748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b613bd18ef9586040862cac56373705f3e65237 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
