Moti Asayag has posted comments on this change. Change subject: engine: Add separate validation for multicast MAC address ......................................................................
Patch Set 1: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/32196/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java: Line 16: public class VmNic extends NetworkInterface<VmNetworkStatistics> { Line 17: Line 18: private static final long serialVersionUID = 7428150502868988886L; Line 19: Line 20: private static final String ODD_HEX_DIGIT_PATTERN = "[13579BbDbFdf]"; please fix: [13579BbDdFf] Line 21: Line 22: public static final String NON_MULTICAST_MAC_ADDRESS_FORMAT = Line 23: ".*(?<!^\\p{XDigit}" + ODD_HEX_DIGIT_PATTERN + "(:\\p{XDigit}{2}){5}$)"; Line 24: public static final String VALID_MAC_ADDRESS_FORMAT = Line 18: private static final long serialVersionUID = 7428150502868988886L; Line 19: Line 20: private static final String ODD_HEX_DIGIT_PATTERN = "[13579BbDbFdf]"; Line 21: Line 22: public static final String NON_MULTICAST_MAC_ADDRESS_FORMAT = Please make required changes to MacAddressPatternTest to reflect the variety of messages in case of a failure. Line 23: ".*(?<!^\\p{XDigit}" + ODD_HEX_DIGIT_PATTERN + "(:\\p{XDigit}{2}){5}$)"; Line 24: public static final String VALID_MAC_ADDRESS_FORMAT = Line 25: "^(\\p{XDigit}{2}:){5}\\p{XDigit}{2}$"; Line 26: http://gerrit.ovirt.org/#/c/32196/1/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 828: VALIDATION.EVENTS.EMAIL_FORMAT=email format is not valid Line 829: VALIDATION_INVALID_CORRELATION_ID=The correlation ID must be formed of "a-z0-9A-Z" or "-_" Line 830: VALIDATION.SOURCE_SNAPSHOT_ID.NOT_NULL=Source snapshot is required Line 831: VALIDATION.VM.NETWORK.MAC.ADDRESS.INVALID=MAC address must be in format "HH:HH:HH:HH:HH:HH" where H is a hexadecimal character (either a digit or A-F, case is insignificant). Line 832: VALIDATION.VM.NETWORK.MAC.ADDRESS.MULTICAST=Multi-cast MAC address is not allowed. please add message to all relevant resource files: frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties Line 833: VALIDATION.VM.NETWORK.MAC.ADDRESS.NOT_NULL=MAC address is required. Line 834: VALIDATION.VM.NETWORK.NAME.NOT_NULL=Interface name is required. Line 835: VALIDATION.CONNECTIVITY.TIMEOUT.INVALID=Connectivity timeout is not valid. Timeout must be between 1 and 120. Line 836: VALIDATION.REPETITIVE.IP.IN.VDS=Invalid list of interfaces, two or more network interfaces have the same IP. -- To view, visit http://gerrit.ovirt.org/32196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4077a14fb61c2e082db9f81f1ded3b25ca98fc3f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
