Moti Asayag has posted comments on this change. Change subject: engine: Add separate validation for multicast MAC address ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/32196/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java: Line 57: private List<PermissionSubject> permissionCheckSubject; Line 58: private List<DiskImage> _templateDisks; Line 59: private StorageDomain sourceDomain; Line 60: private Guid sourceDomainId = Guid.Empty; Line 61: private final static Pattern VALIDATE_MAC_ADDRESS = Pattern.compile("\\p{XDigit}[02468AaCcEe](:\\p{XDigit}{2}){5}"); > I think this should be defined on one place. Not saying that VmNic is good +1 - seems that ValidationUtils is a better location or perhaps introduce ValidationPatterns Line 62: Line 63: /** Line 64: * Constructor for command creation when compensation is applied on startup Line 65: * -- To view, visit http://gerrit.ovirt.org/32196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4077a14fb61c2e082db9f81f1ded3b25ca98fc3f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
