Moti Asayag has posted comments on this change. Change subject: engine: Add separate validation for multicast MAC address ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/32196/3/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MacAddressPatternTest.java File backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MacAddressPatternTest.java: Line 51: if (validMacAddress) { Line 52: assertTrue(validate.isEmpty()); Line 53: } else { Line 54: assertEquals(1, validate.size()); Line 55: assertTrue(validate.iterator().next().getMessage().equals(message)); why not use assertEquals as well ? Line 56: } Line 57: } Line 58: Line 59: private VmNic createVmNic() { -- To view, visit http://gerrit.ovirt.org/32196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4077a14fb61c2e082db9f81f1ded3b25ca98fc3f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
