Allon Mureinik has posted comments on this change. Change subject: core: AddVmTemplateCommand storage allocation ......................................................................
Patch Set 4: Code-Review-1 (8 comments) http://gerrit.ovirt.org/#/c/15378/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 159: protected void updateVmDevices() { Line 160: VmDeviceUtils.setVmDevices(getVm().getStaticData()); Line 161: } Line 162: Line 163: protected ArrayList<DiskImage> getVmDisksFromDB() { can this be a List instead of an ArrayList ? Line 164: VmHandler.updateDisksFromDb(getVm()); Line 165: VmHandler.filterImageDisksForVM(getVm(), false, false, true); Line 166: return getVm().getDiskList(); Line 167: } Line 497: Line 498: protected boolean validateSpaceRequirements() { Line 499: // update vm snapshots for storage free space check Line 500: ImagesHandler.fillImagesBySnapshots(getVm()); Line 501: List<DiskImage> disksList = ImagesHandler.filterImageDisks(getVm().getDiskMap().values(), true, false, true); This is already done in imagesRelatedChecks(), isn't it? Line 502: List<DiskImage> disksListForStorageChecks = createDiskDummiesForSpaceValidations(disksList); Line 503: MultipleStorageDomainsValidator multipleSdValidator = getStorageDomainsValidator( Line 504: getVm().getStoragePoolId(), getStorageGuidSet()); Line 505: http://gerrit.ovirt.org/#/c/15378/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java: Line 256 Line 257 Line 258 Line 259 Line 260 yay! http://gerrit.ovirt.org/#/c/15378/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java: Line 37: import org.ovirt.engine.core.dao.VmDAO; Line 38: import org.ovirt.engine.core.utils.MockConfigRule; Line 39: Line 40: import java.util.ArrayList; Line 41: import java.util.Collections; Should be on top - please check your formatter Line 42: Line 43: /** A test case for {@link AddVmTemplateCommand} */ Line 44: @RunWith(MockitoJUnitRunner.class) Line 45: public class AddVmTemplateCommandTest { Line 44: @RunWith(MockitoJUnitRunner.class) Line 45: public class AddVmTemplateCommandTest { Line 46: Line 47: private AddVmTemplateCommand<AddVmTemplateParameters> cmd; Line 48: Why? Line 49: private VM vm; Line 50: Line 51: private VDSGroup vdsGroup; Line 52: Line 46: Line 47: private AddVmTemplateCommand<AddVmTemplateParameters> cmd; Line 48: Line 49: private VM vm; Line 50: why? Line 51: private VDSGroup vdsGroup; Line 52: Line 53: private Guid spId; Line 54: Line 48: Line 49: private VM vm; Line 50: Line 51: private VDSGroup vdsGroup; Line 52: why? Line 53: private Guid spId; Line 54: Line 55: @Mock Line 56: private VmDAO vmDao; Line 157: setupForStorageTests(); Line 158: doReturn(new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_STORAGE_DOMAIN)). Line 159: when(multipleSdValidator).allDomainsHaveSpaceForClonedDisks(anyList()); Line 160: assertFalse(cmd.imagesRelatedChecks()); Line 161: } For all of these, please use the assertThat (something, failsWith...) idiom Line 162: Line 163: Line 164: @Test Line 165: public void testBeanValidations() { -- To view, visit http://gerrit.ovirt.org/15378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7980510a7bb72e43e0a9dfc18460207386eb62fe Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
