Arik Hadas has posted comments on this change. Change subject: core: AddVmTemplateCommand storage allocation ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/15378/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 496: } Line 497: Line 498: protected boolean validateSpaceRequirements() { Line 499: // update vm snapshots for storage free space check Line 500: ImagesHandler.fillImagesBySnapshots(getVm()); when creating template, the disks are collapsed. iiuc, the call above take the snapshots into consideration and in that case it is wrong, am I right? Line 501: List<DiskImage> disksList = ImagesHandler.filterImageDisks(getVm().getDiskMap().values(), true, false, true); Line 502: List<DiskImage> disksListForStorageChecks = createDiskDummiesForSpaceValidations(disksList); Line 503: MultipleStorageDomainsValidator multipleSdValidator = getStorageDomainsValidator( Line 504: getVm().getStoragePoolId(), getStorageGuidSet()); -- To view, visit http://gerrit.ovirt.org/15378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7980510a7bb72e43e0a9dfc18460207386eb62fe Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
