Vered Volansky has posted comments on this change. Change subject: core: AddVmTemplateCommand storage allocation ......................................................................
Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/15378/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 159: protected void updateVmDevices() { Line 160: VmDeviceUtils.setVmDevices(getVm().getStaticData()); Line 161: } Line 162: Line 163: protected ArrayList<DiskImage> getVmDisksFromDB() { > can this be a List instead of an ArrayList ? Done Line 164: VmHandler.updateDisksFromDb(getVm()); Line 165: VmHandler.filterImageDisksForVM(getVm(), false, false, true); Line 166: return getVm().getDiskList(); Line 167: } Line 497: Line 498: protected boolean validateSpaceRequirements() { Line 499: // update vm snapshots for storage free space check Line 500: ImagesHandler.fillImagesBySnapshots(getVm()); Line 501: List<DiskImage> disksList = ImagesHandler.filterImageDisks(getVm().getDiskMap().values(), true, false, true); > This is already done in imagesRelatedChecks(), isn't it? On mImages. Line 502: List<DiskImage> disksListForStorageChecks = createDiskDummiesForSpaceValidations(disksList); Line 503: MultipleStorageDomainsValidator multipleSdValidator = getStorageDomainsValidator( Line 504: getVm().getStoragePoolId(), getStorageGuidSet()); Line 505: http://gerrit.ovirt.org/#/c/15378/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java: Line 256 Line 257 Line 258 Line 259 Line 260 > yay! Best part :) http://gerrit.ovirt.org/#/c/15378/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java: Line 157: setupForStorageTests(); Line 158: doReturn(new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_STORAGE_DOMAIN)). Line 159: when(multipleSdValidator).allDomainsHaveSpaceForClonedDisks(anyList()); Line 160: assertFalse(cmd.imagesRelatedChecks()); Line 161: } > For all of these, please use the assertThat (something, failsWith...) idiom In a previous patch we've established that the nicety of assertThat goes to hell without ValidationResult, and that with boolean it doesn't matter, which is also the case here. Line 162: Line 163: Line 164: @Test Line 165: public void testBeanValidations() { -- To view, visit http://gerrit.ovirt.org/15378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7980510a7bb72e43e0a9dfc18460207386eb62fe Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
