Gilad Chaplik has posted comments on this change. Change subject: core: Create default disk profiles for data domains ......................................................................
Patch Set 2: (4 comments) minor comments http://gerrit.ovirt.org/#/c/34422/2//COMMIT_MSG Commit Message: Line 6: Line 7: core: Create default disk profiles for data domains Line 8: Line 9: All data domains should have default disk prifiles with unlimited QoS Line 10: (currentlu implemented by null) currently Line 11: Line 12: Otherwise all existing data domains needs manual intervention for Line 13: creating disks if the data center is upgraded to version 3.5 Line 14: Line 8: Line 9: All data domains should have default disk prifiles with unlimited QoS Line 10: (currentlu implemented by null) Line 11: Line 12: Otherwise all existing data domains needs manual intervention for need Line 13: creating disks if the data center is upgraded to version 3.5 Line 14: Line 15: Change-Id: I3ee3174e5c7bef3bcd5591b9cd99ff5324bee488 Line 16: Bug-Url: https://bugzilla.redhat.com/1145241 http://gerrit.ovirt.org/#/c/34422/2/packaging/dbscripts/upgrade/03_06_0460_create_default_disk_profiles.sql File packaging/dbscripts/upgrade/03_06_0460_create_default_disk_profiles.sql: Line 1: CREATE OR REPLACE FUNCTION create_default_disk_profiles() RETURNS VOID AS $$ call the method and delete it afterwards. Line 2: DECLARE Line 3: sd_id uuid; Line 4: BEGIN Line 5: RAISE NOTICE 'Assigning defaults disk profiles for all storage domains...'; Line 11: Line 12: RAISE NOTICE 'Assigning default disk profile to storage domain %s ...', sd_id; Line 13: Line 14: INSERT INTO disk_profiles VALUES Line 15: (uuid_generate_v1(), 'Default', sd_id, NULL, 'Default unlimited disk profile'); please use the storage domain name (uniformity with current behavior) Line 16: Line 17: END LOOP; Line 18: Line 19: RAISE NOTICE 'Done Assigning default disk profiles.'; -- To view, visit http://gerrit.ovirt.org/34422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ee3174e5c7bef3bcd5591b9cd99ff5324bee488 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
