Allon Mureinik has posted comments on this change. Change subject: core: Create default disk profiles for data domains ......................................................................
Patch Set 3: Code-Review+2 (3 comments) +2 on the code, please fix the typos before merging. http://gerrit.ovirt.org/#/c/34422/3//COMMIT_MSG Commit Message: Line 6: Line 7: core: Create default disk profiles for data domains Line 8: Line 9: All data domains should have default disk prifiles with unlimited QoS Line 10: (currentlu implemented by null) s/currentlu/currently/ Line 11: Line 12: Otherwise all existing data domains needs manual intervention for Line 13: creating disks if the data center is upgraded to version 3.5 Line 14: http://gerrit.ovirt.org/#/c/34422/3/packaging/dbscripts/upgrade/03_06_0460_create_default_disk_profiles.sql File packaging/dbscripts/upgrade/03_06_0460_create_default_disk_profiles.sql: Line 1: CREATE OR REPLACE FUNCTION create_default_disk_profiles() RETURNS VOID AS $$ Line 2: DECLARE Line 3: sd_id uuid; Line 4: BEGIN Line 5: RAISE NOTICE 'Assigning defaults disk profiles for all storage domains...'; s/defaults/default/ Line 6: Line 7: INSERT INTO disk_profiles Line 8: (SELECT uuid_generate_v1(), storage_name, id, NULL, 'Default unlimited disk profile' Line 9: FROM storage_domain_static Line 6: Line 7: INSERT INTO disk_profiles Line 8: (SELECT uuid_generate_v1(), storage_name, id, NULL, 'Default unlimited disk profile' Line 9: FROM storage_domain_static Line 10: WHERE storage_domain_type IN (0,1) -- 0 and 1 are data domains type s/domains type/domain types/ Line 11: AND id NOT IN (select storage_domain_id from disk_profiles)); Line 12: Line 13: RAISE NOTICE 'Done Assigning default disk profiles.'; Line 14: RETURN ; -- To view, visit http://gerrit.ovirt.org/34422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ee3174e5c7bef3bcd5591b9cd99ff5324bee488 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
