Allon Mureinik has posted comments on this change. Change subject: core: Create default disk profiles for data domains ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/34422/2/packaging/dbscripts/upgrade/03_06_0460_create_default_disk_profiles.sql File packaging/dbscripts/upgrade/03_06_0460_create_default_disk_profiles.sql: Line 14: INSERT INTO disk_profiles VALUES Line 15: (uuid_generate_v1(), 'Default', sd_id, NULL, 'Default unlimited disk profile'); Line 16: Line 17: END LOOP; Line 18: Why do we need this loop? Why not just do a bulk insert? INSERT INTO disk_profiles (SELECT uuid_generate_v1(), 'Default', sd_id, NULL, 'Default unlimited disk profile' FROM storage_domain_static WHERE storage_domain_type IN (0,1) -- 0 and 1 are data domains type AND id NOT IN (select storage_domain_id from disk_profiles) ) Line 19: RAISE NOTICE 'Done Assigning default disk profiles.'; Line 20: RETURN ; Line 21: END; -- To view, visit http://gerrit.ovirt.org/34422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ee3174e5c7bef3bcd5591b9cd99ff5324bee488 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
