Maor Lipchuk has posted comments on this change.
Change subject: core: ImportVmCommand - added method getUpdatedVmForOperation()
......................................................................
Patch Set 8: (1 inline comment)
maybe we can add a method called getVm(boolean cache) which will fetch the VM
from the DB if we will call it with cache=false. Since now the implementation
is kind of a hack.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 913: private VM getUpdatedVmForOperation() {
Suggestion: I would rename this method to getVmFromDb
BTW maybe we can add a method called getVm(boolean cache) which will fetch the
VM from the DB if we will call it with cache=false.
Since now the implementation is kind of a hack.
--
To view, visit http://gerrit.ovirt.org/6507
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f53af1324fc1aed32bdf8ec1eac9b7f7d307f25
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
