Allon Mureinik has posted comments on this change. Change subject: core: ImportVmCommand - added method getUpdatedVmForOperation() ......................................................................
Patch Set 9: I would prefer that you didn't submit this (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java Line 91: private final List<Guid> diskGuidList = new ArrayList<Guid>(); why would you change the member to final? and even if so, why in this patch? Line 92: private final List<Guid> imageGuidList = new ArrayList<Guid>(); same question. Line 914: * this method return the updated Vm for the above operation, the method may reload the VM from the DB. s/return/returns/ Or even better, just use "@return The updated VM..." -- To view, visit http://gerrit.ovirt.org/6507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f53af1324fc1aed32bdf8ec1eac9b7f7d307f25 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
