Liron Aravot has posted comments on this change.

Change subject: core: ImportVmCommand - added method getUpdatedVmForOperation()
......................................................................


Patch Set 9: (3 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 87:     private static final long serialVersionUID = -5500615685812075744L;
Line 88: 
Line 89:     private static VmStatic vmStaticForDefaultValues = new VmStatic();
Line 90:     private List<DiskImage> imageList;
Line 91:     private final List<Guid> diskGuidList = new ArrayList<Guid>();
Done
Line 92:     private final List<Guid> imageGuidList = new ArrayList<Guid>();
Line 93: 
Line 94:     public ImportVmCommand(ImportVmParameters parameters) {
Line 95:         super(parameters);


Line 88: 
Line 89:     private static VmStatic vmStaticForDefaultValues = new VmStatic();
Line 90:     private List<DiskImage> imageList;
Line 91:     private final List<Guid> diskGuidList = new ArrayList<Guid>();
Line 92:     private final List<Guid> imageGuidList = new ArrayList<Guid>();
Done
Line 93: 
Line 94:     public ImportVmCommand(ImportVmParameters parameters) {
Line 95:         super(parameters);
Line 96:         setVmId(parameters.getContainerId());


Line 910:         }
Line 911:     }
Line 912: 
Line 913:     /**
Line 914:      * this method return the updated Vm for the above operation, the 
method may reload the VM from the DB.
Done
Line 915:      * @return
Line 916:      */
Line 917:     private VM getUpdatedVmForOperation() {
Line 918:         setVm(null);


--
To view, visit http://gerrit.ovirt.org/6507
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f53af1324fc1aed32bdf8ec1eac9b7f7d307f25
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to