Michael Pasternak has posted comments on this change.
Change subject: restapi: Add enum validations
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
well done Ori! (couple of comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 1432
Line 1433
Line 1434
Line 1435
Line 1436
why did you removed this? how this is related to this patch?
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/ValidatorLocator.java
Line 25: public class ValidatorLocator {
Line 26:
Line 27: private static Map<Class<?>, Validator<?>> validators = new
HashMap<Class<?>, Validator<?>>();
Line 28:
Line 29: static {
why not dynamically discover all validators as we do for mappers?
Line 30: validators.put(Boot.class, new BootValidator());
Line 31: validators.put(Cluster.class, new ClusterValidator());
Line 32: validators.put(DataCenter.class, new DataCenterValidator());
Line 33: validators.put(Disk.class, new DiskValidator());
--
To view, visit http://gerrit.ovirt.org/7218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32b575589a7c82cb2d9e6da8d4d852a50f0f595f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
