Michael Pasternak has posted comments on this change.
Change subject: restapi: Add enum validations
......................................................................
Patch Set 6: Looks good to me, approved
(1 inline comment)
+2 after fixing AbstractBackendResource
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java
Line 69: resource.setSessionHelper(sessionHelper);
Line 70: resource.setMessageBundle(messageBundle);
Line 71: resource.setUriInfo(uriInfo);
Line 72: resource.setHttpHeaders(httpHeaders);
Line 73: resource.setValidatorLocator(validatorLocator);
why do you set it twice?
Line 74: return resource;
Line 75: }
Line 76:
Line 77: protected <F, T> Mapper<F, T> getMapper(Class<F> from, Class<T>
to) {
--
To view, visit http://gerrit.ovirt.org/7218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32b575589a7c82cb2d9e6da8d4d852a50f0f595f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
