Michael Pasternak has posted comments on this change.

Change subject: restapi: Add enum validations
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java
Line 159:         }
Line 160:         else if (resource instanceof CapabilitiesResource) {
Line 161:             ((BackendCapabilitiesResource) 
resource).setMappingLocator(mappingLocator);
Line 162:         }
Line 163:         resource.setValidatorLocator(validatorLocator);
using this approach only root collections will have validatorLocator, all 
sub-collections/resources will get NPE, when you'll try to use it,

you need to inject it in runtime to every resource.
Line 164:         singletons.add(resource);
Line 165:     }
Line 166: 
Line 167:     @Override


--
To view, visit http://gerrit.ovirt.org/7218
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32b575589a7c82cb2d9e6da8d4d852a50f0f595f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to