Eldan Shachar has posted comments on this change. Change subject: core: Editing of template version for stateless VMs and pools ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36507/1/packaging/dbscripts/upgrade/03_06_0700_add_template_id_to_pool.sql File packaging/dbscripts/upgrade/03_06_0700_add_template_id_to_pool.sql: Line 1: SELECT fn_db_add_column('vm_pools', 'vm_pool_vmt_guid', 'uuid'); Line 2: SELECT fn_db_add_column('vm_pools', 'vm_pool_is_latest', 'boolean'); > please consider rename with the is_ as prefix Done Line 3: Line 4: -- Updating pool with template-id based on vm_static data (at this point it's still safe). Line 5: -- From this point on different VMs in a pool may have different template versions (in a NEXT-RUN use case). Line 6: UPDATE vm_pools SET vm_pool_vmt_guid=(SELECT vmt_guid FROM vm_static INNER JOIN vm_pool_map ON vm_static.vm_guid=vm_pool_map.vm_guid WHERE vm_pool_map.vm_pool_id=vm_pools.vm_pool_id LIMIT 1); -- To view, visit http://gerrit.ovirt.org/36507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib106016955c702bc28f9347d828c4602e47bd233 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eldan Shachar <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
