Arik Hadas has posted comments on this change. Change subject: core: Editing of template version for stateless VMs and pools ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/36507/3/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java: Line 224: * Retrieves the list of all VMS from a given pool. Line 225: * Line 226: * @return the list of all VMs in the pool Line 227: */ Line 228: List<VM> getPoolVms(Guid poolId); already exists - getAllForVmPool Line 229: Line 230: /** Line 231: * Saves the is_initialized property of the VM. Line 232: * http://gerrit.ovirt.org/#/c/36507/3/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java: Line 133: return returnValue; Line 134: } Line 135: Line 136: private boolean isStatelessField(String name) { Line 137: return hotsetAllowedFields.contains(name); s\hotsetAllowedFields\statelessAllowedFields Line 138: } Line 139: Line 140: /** Line 141: * This method will copy all fields that are not @editable from source obj to dest obj http://gerrit.ovirt.org/#/c/36507/3/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 906: FROM user_vm_permissions_view Line 907: WHERE user_id = v_user_id AND entity_id = vm_guid)) Line 908: ORDER BY vm_guid; Line 909: END; $procedure$ Line 910: LANGUAGE plpgsql; already exists - GetVmsByVmPoolId Line 911: Line 912: Line 913: Line 914: -- To view, visit http://gerrit.ovirt.org/36507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib106016955c702bc28f9347d828c4602e47bd233 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eldan Shachar <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
