Eli Mesika has posted comments on this change. Change subject: core: Editing of template version for stateless VMs and pools ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36507/3/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 898: Line 899: Create or replace FUNCTION GetPoolVmsFromVms(v_user_id UUID, v_pool_id UUID, v_is_filtered boolean) RETURNS SETOF vms STABLE Line 900: AS $procedure$ Line 901: BEGIN Line 902: RETURN QUERY SELECT DISTINCT vms.* > Used legacy code as reference and assumed it's there to protect against sce Please test without it and see if you have a problem, we can always add that but if there is no clear reason we will not copy/paste it since this affects performance Line 903: FROM vms Line 904: WHERE vm_pool_id = v_pool_id AND Line 905: (NOT v_is_filtered OR EXISTS (SELECT 1 Line 906: FROM user_vm_permissions_view -- To view, visit http://gerrit.ovirt.org/36507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib106016955c702bc28f9347d828c4602e47bd233 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eldan Shachar <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
