Alon Bar-Lev has posted comments on this change. Change subject: aaa : Add engine sso ......................................................................
Patch Set 30: (2 comments) http://gerrit.ovirt.org/#/c/36119/30/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java: Line 38: public static final String LOGIN_PHASE2_URI = "/login-phase2"; Line 39: public static final String LOGIN_PHASE3_URI = "/login-phase3"; Line 40: public static final String ENABLE_EXTERNAL_AUTH = "enable-external-auth"; Line 41: public static final String ACCEPT_BASIC_AUTH_HEADERS = "accept-basic-auth-headers"; Line 42: public static final String ENABLE_BASIC_AUTH = "enable-basic-auth"; I believe there are some of the above that are of basic patch, maybe just squash the two patches? Line 43: Line 44: public static boolean isUserAuthenticated(HttpSession session) { Line 45: return session.getAttribute(SSO_PRINCIPAL_RECORD_ATTR_NAME) != null; Line 46: } http://gerrit.ovirt.org/#/c/36119/30/backend/manager/modules/enginesso/src/main/webapp/WEB-INF/web.xml File backend/manager/modules/enginesso/src/main/webapp/WEB-INF/web.xml: Line 115: <servlet-name>LogoutServlet</servlet-name> Line 116: <servlet-class>org.ovirt.engine.core.sso.servlets.LogoutServlet</servlet-class> Line 117: <init-param> Line 118: <param-name>welcome-url</param-name> Line 119: <param-value>/ovirt-engine/</param-value> maybe move all parameters to webapp context parameters? it will be easier to track these and read them to context at one place. please remember that we should read these from configuration using the %{xxx} pattern and expand string using the shell like config. Line 120: </init-param> Line 121: </servlet> Line 122: Line 123: <servlet-mapping> -- To view, visit http://gerrit.ovirt.org/36119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa Gerrit-PatchSet: 30 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
