Alon Bar-Lev has posted comments on this change. Change subject: aaa : Add engine sso ......................................................................
Patch Set 30: (1 comment) http://gerrit.ovirt.org/#/c/36119/30/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSOContextListener.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSOContextListener.java: Line 18: SSOLocalConfig localConfig = new SSOLocalConfig(); Line 19: ctx.setAttribute(SSOUtils.EXTENSION_MANAGER, new SSOExtensionsManager(localConfig)); Line 20: ctx.setAttribute(SSOUtils.USER_GROUP_MANAGER, new SSOUserGroupManager()); Line 21: ctx.setAttribute(SSOUtils.SSO_LOCAL_CONFIG, localConfig); Line 22: ctx.setAttribute(SSOUtils.SSO_PROFILES, AuthenticationUtils.getAvailableProfiles(ctx)); I think it will be easier to set one key with a class, and access it all over instead of the casting and such. Line 23: } Line 24: Line 25: @Override Line 26: public void contextDestroyed(ServletContextEvent event) { -- To view, visit http://gerrit.ovirt.org/36119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa Gerrit-PatchSet: 30 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
