Oved Ourfali has posted comments on this change. Change subject: [WIP] core: delete last domain fails with engine-manage-domain (#851069) ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 6: Line 7: [WIP] core: delete last domain fails with engine-manage-domain (#851069) Line 8: Line 9: Setting AdUserPassword to empty string was not validate, because this Line 10: value type is CompositePassword, CompositePassword is defined to be Also, this sentence is too long, and unclear. Please rephrase. Line 11: structured as username:password. CompositePasswordValueHelper:valid Line 12: method is verifing it. Line 13: Now it lets us also assign empty string to CompositePassword. Line 14: -- To view, visit http://gerrit.ovirt.org/7604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d4904a916f2055288e99114f2f267face16797b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
