Yair Zaslavsky has posted comments on this change. Change subject: [WIP] core: delete last domain fails with engine-manage-domain (#851069) ......................................................................
Patch Set 1: Looks good to me, approved (2 inline comments) Looks good, just fix the commit msg Well done! .................................................... Commit Message Line 3: AuthorDate: 2012-08-30 12:22:16 +0300 Line 4: Commit: Yaniv Bronhaim <[email protected]> Line 5: CommitDate: 2012-08-30 12:34:21 +0300 Line 6: Line 7: [WIP] core: delete last domain fails with engine-manage-domain (#851069) Just remember to remove [WIP] prefix before final submission. We usually place [WIP] when we're still in the middle of a thought /design and we would like others to take a look, but not submit this (as this is Work In Progress) Line 8: Line 9: Setting AdUserPassword to empty string was not validate, because this Line 10: value type is CompositePassword, CompositePassword is defined to be Line 11: structured as username:password. CompositePasswordValueHelper:valid Line 5: CommitDate: 2012-08-30 12:34:21 +0300 Line 6: Line 7: [WIP] core: delete last domain fails with engine-manage-domain (#851069) Line 8: Line 9: Setting AdUserPassword to empty string was not validate, because this s/validate/validated Or maybe - s/validate/carried out Line 10: value type is CompositePassword, CompositePassword is defined to be Line 11: structured as username:password. CompositePasswordValueHelper:valid Line 12: method is verifing it. Line 13: Now it lets us also assign empty string to CompositePassword. -- To view, visit http://gerrit.ovirt.org/7604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d4904a916f2055288e99114f2f267face16797b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
