Mike Kolesnik has posted comments on this change.
Change subject: engine: Prevent networks with different MTU (#852052)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java
Line 123:
Line 124: private void reportMTUDifferences(List<Network> ifaceNetworks) {
Line 125: List<String> mtuDiffNetworks = new ArrayList<String>();
Line 126: for (Network net : ifaceNetworks) {
Line 127: mtuDiffNetworks.add(String.format("%s(%d)",
net.getName(), net.getMtu()));
MTU 0 should be logged differently (i.e. "default" or something similar).
Line 128: }
Line 129: addViolation(VdcBllMessages.NETWORK_MTU_DIFFERENCES,
Line 130: String.format("[%s]",
StringUtils.join(mtuDiffNetworks, ", ")));
Line 131: }
--
To view, visit http://gerrit.ovirt.org/7661
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69f5c5f515d782c0311fd7fe458408ed634c1c83
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
