Moti Asayag has posted comments on this change.

Change subject: engine: Prevent networks with different MTU (#852052)
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 431: NETWORKS_DONT_EXIST_IN_CLUSTER=Cannot ${action} ${type}. The 
following Logical Networks don't exist in the Host's Cluster: 
${NETWORKS_DONT_EXIST_IN_CLUSTER_LIST}.
Line 432: NETWORK_BONDS_INVALID_SLAVE_COUNT=Cannot ${action} ${type}. The 
following Bonds consist of less than two Network Interfaces: 
${NETWORK_BONDS_INVALID_SLAVE_COUNT_LIST}.
Line 433: NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS=Cannot ${action} ${type}. 
The following VMs are actively using the Logical Network: 
${NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS_LIST}. Please stop the VMs and try 
again.
Line 434: NON_VM_NETWORK_CANNOT_SUPPORT_STP=Cannot ${action} ${type}. STP can 
only be enabled on VM Networks.
Line 435: NETWORK_MTU_DIFFERENCES=Cannot ${action} ${type}. The following 
Logical Networks don't have the same MTU value: ${NETWORK_MTU_DIFFERENCES_LIST}.
non-Vm network might be also Vlan, therefore the message will not be accurate. 
Adding 'non-VM and without Vlan' will make this message cumbersome.

A user will see a list of networks without knowing what is the type of each 
network, only noticed is the difference in the MTU.
Line 436: CANNOT_PREIEW_CURRENT_IMAGE=The currently used VM Snapshot Image 
cannot be used in Preview command.
Line 437: CONFIG_UNKNOWN_KEY=Illegal configuration entry.\n\
Line 438:       -Please check configuration entry name.
Line 439: TAGS_SPECIFIED_TAG_CANNOT_BE_THE_PARENT_OF_ITSELF=Operation canceled, 
recursive Tag hierarchy cannot be defined.


--
To view, visit http://gerrit.ovirt.org/7661
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69f5c5f515d782c0311fd7fe458408ed634c1c83
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to