Muli Salem has posted comments on this change.
Change subject: engine: Prevent networks with different MTU (#852052)
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java
Line 817: * </pre>
Line 818: */
Line 819: @Test
Line 820: public void nonVmWithSameMTUAddedToNic() {
Line 821: Network net = createNetwork("VLanVmMtu9000");
camel case: vlanVm - for entire patch.
Line 822: net.setvlan_id(100);
Line 823: net.setMtu(9000);
Line 824: Network newNet = createNetwork("nonVmMtu5000");
Line 825: newNet.setVmNetwork(false);
Line 820: public void nonVmWithSameMTUAddedToNic() {
Line 821: Network net = createNetwork("VLanVmMtu9000");
Line 822: net.setvlan_id(100);
Line 823: net.setMtu(9000);
Line 824: Network newNet = createNetwork("nonVmMtu5000");
5000 --> 9000
Line 825: newNet.setVmNetwork(false);
Line 826: newNet.setMtu(9000);
Line 827: mockExistingNetworks(net, newNet);
Line 828:
Line 960: public void nonVmWithDefaultMTUAddedToNic() {
Line 961: Network net = createNetwork("VLanVmMtu9000");
Line 962: net.setvlan_id(100);
Line 963: net.setMtu(9000);
Line 964: Network newNet = createNetwork("nonVmMtu5000");
nonVmMtu5000 ==> nonVm
Line 965: newNet.setVmNetwork(false);
Line 966: mockExistingNetworks(net, newNet);
Line 967:
Line 968: VdsNetworkInterface nic = createNic("nic0", null);
Line 996: public void nonVmLanWithDifferentMTUAddedToNic() {
Line 997: Network net = createNetwork("VLanVmMtu9000");
Line 998: net.setvlan_id(100);
Line 999: net.setMtu(9000);
Line 1000: Network newNet = createNetwork("nonVmVLanVmMtu9000");
nonVmVLanVmMtu9000 ==> vlanNonVmMtu9000
Line 1001: newNet.setvlan_id(200);
Line 1002: newNet.setMtu(5000);
Line 1003: newNet.setVmNetwork(false);
Line 1004: mockExistingNetworks(net, newNet);
--
To view, visit http://gerrit.ovirt.org/7661
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69f5c5f515d782c0311fd7fe458408ed634c1c83
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
