Alon Bar-Lev has posted comments on this change.

Change subject: packaging: moving .pgpass to a common location
......................................................................


Patch Set 2: (1 inline comment)

Stupid question... where do we create this file?

....................................................
File packaging/fedora/setup/common_utils.py
Line 326:     return ("".join(output.splitlines(True)), proc.returncode)
Line 327: 
Line 328: def execSqlCommand(userName, dbName, sqlQuery, failOnError=False, 
errMsg=output_messages.ERR_SQL_CODE):
Line 329:     logging.debug("running sql query \'%s\' on db." % sqlQuery)
Line 330:     os.environ["PGPASSFILE"] = basedefs.DB_PASS_FILE
Can't you effect environment of this specific command?
Line 331:     cmd = [
Line 332:         basedefs.EXEC_PSQL,
Line 333:         "-U", userName,
Line 334:         "-d", dbName,


--
To view, visit http://gerrit.ovirt.org/7665
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dece89583f3066fbd7d3ccd68cdbd14d94cf12a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to