Alon Bar-Lev has posted comments on this change.
Change subject: packaging: moving .pgpass to a common location
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File backend/manager/dbscripts/dbcustomfunctions.sh
Line 14: DATABASE="engine"
Line 15: USERNAME=""
Line 16: VERBOSE=false
Line 17: LOGFILE="$ME.log"
Line 18: export PGPASSFILE="/etc/ovirt-engine/.pgpass"
I would prefer to use ENGINE_PGPASS= here without the export and add:
PGPASSFILE="${ENGINE_PGPASS}" psql ...
Where psql is actually used... unless there are too many places.
Line 19: }
Line 20:
Line 21: #refreshes views
Line 22: refresh_views() {
....................................................
File packaging/fedora/setup/common_utils.py
Line 302: (stdOutFD, stdOutFile) = tempfile.mkstemp(dir="/tmp")
Line 303: (stdInFD, stdInFile) = tempfile.mkstemp(dir="/tmp")
Line 304:
Line 305: # Update os.environ with env if provided
Line 306: os.environ.update(envDict or {})
You change the process environment here, or I miss something?
Line 307:
Line 308: # We use close_fds to close any file descriptors we have so it
won't be copied to forked childs
Line 309: proc = subprocess.Popen(cmd, stdout=stdOutFD,
Line 310: stderr=stdErrFD, stdin=stdInFD, cwd=cwd, shell=useShell,
close_fds=True)
--
To view, visit http://gerrit.ovirt.org/7665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dece89583f3066fbd7d3ccd68cdbd14d94cf12a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
