Alon Bar-Lev has posted comments on this change.
Change subject: packaging: moving .pgpass to a common location
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File backend/manager/dbscripts/engine-db-install.sh
Line 97: SHELL=/bin/sh
Line 98: PSQL_BIN=/usr/bin/psql
Line 99:
Line 100: # Update PSQL BIN to include .pgpass environment variable, host and
port values
Line 101: ENGINE_PGPASS=/etc/ovirt-engine/.pgpass
Question1: why not forward this as a parameter to this script? and not hard
code this here?
Question2: why do we need the user and password if we pass this file?
Sorry for the late understanding...
Line 102: PSQL="${PSQL_BIN} -h $DB_HOST -p $DB_PORT"
Line 103:
Line 104: if [[ "x${REMOTE_INSTALL}" == "xremote" ]]
Line 105: then
--
To view, visit http://gerrit.ovirt.org/7665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dece89583f3066fbd7d3ccd68cdbd14d94cf12a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
