Alexander Wels has posted comments on this change. Change subject: engine, webadmin: Allow to specify disk error_policy in Web UI ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/38329/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java: Line 120: @Ignore Line 121: AdvancedParametersExpander expander; Line 122: Line 123: @UiField Line 124: @Ignore Any particular reason you are ignoring the flow panel. it shouldn't be an issue. Line 125: FlowPanel expanderContent; Line 126: Line 127: @UiField(provided = true) Line 128: @Path("diskErrorPolicy.selectedItem") https://gerrit.ovirt.org/#/c/38329/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 3285: DiskErrorPolicy.STOP, Line 3286: DiskErrorPolicy.IGNORE Line 3287: })); Line 3288: Line 3289: return diskErrorPolicy; I think: return Arrays.asList({DiskErrorPolicy.REPORT, DiskErrorPolicy.ENOSPC, DiskErrorPolicy.STOP, DiskErrorPolicy.IGNORE}); Is more concise and doesn't create as many array lists. Line 3290: } Line 3291: Line 3292: public String getNewNicName(Collection<VmNetworkInterface> existingInterfaces) Line 3293: { -- To view, visit https://gerrit.ovirt.org/38329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4bed1019f94064b9800fda0fb17a6def46ab221 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
