Ravi Nori has posted comments on this change. Change subject: engine, webadmin: Allow to specify disk error_policy in Web UI ......................................................................
Patch Set 5: (3 comments) https://gerrit.ovirt.org/#/c/38329/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java: Line 66: drive.put(VdsProperties.PoolId, diskImage.getStoragePoolId().toString()); Line 67: drive.put(VdsProperties.VolumeId, diskImage.getImageId().toString()); Line 68: drive.put(VdsProperties.ImageId, diskImage.getId().toString()); Line 69: drive.put(VdsProperties.PropagateErrors, disk.getPropagateErrors().toString().toLowerCase()); Line 70: drive.put(VdsProperties.DiskErrorPolicy, disk.getDiskErrorPolicy().toString().toLowerCase()); > is it relevant only for images? For Lun disks I see propagate errors has been set to off. I am not sure for Lun disks I need to set PropagateErrors and DiskErrorPolicy similar to Images. Please confirm Line 71: Line 72: VmInfoBuilder.handleIoTune(getParameters().getVm(), vmDevice, diskImage, Line 73: new HashMap<Guid, Guid>(), new HashMap<Guid, Map<String, Long>>()); Line 74: if (vmDevice.getSpecParams() != null) { https://gerrit.ovirt.org/#/c/38329/5/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java: Line 125: Line 126: @UiField(provided = true) Line 127: @Path("diskErrorPolicy.selectedItem") Line 128: @WithElementId("diskErrorPolicy") Line 129: ListModelListBoxEditor<DiskErrorPolicy> diskErrorPolicyEditor; > if relevant only for images, then should be hidden for direct lun Done Line 130: Line 131: @UiField(provided = true) Line 132: @Path("quota.selectedItem") Line 133: @WithElementId("quota") https://gerrit.ovirt.org/#/c/38329/5/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml: Line 95: <ge:EntityModelCheckBoxEditor ui:field="isScsiPassthroughEditor" addStyleNames="{style.checkBoxEditor}"/> Line 96: <ge:EntityModelCheckBoxEditor ui:field="isSgIoUnfilteredEditor" addStyleNames="{style.checkBoxEditor} {style.checkBoxSecondary}"/> Line 97: </g:VerticalPanel> Line 98: </g:HorizontalPanel> Line 99: <d:AdvancedParametersExpander ui:field="expander"/> > not sure it worth having an expander just for this editor, maybe just keep Will do Line 100: <g:FlowPanel ui:field="expanderContent"> Line 101: <e:ListModelListBoxEditor ui:field="diskErrorPolicyEditor" addStyleNames="{style.boxEditor}"/> Line 102: </g:FlowPanel> Line 103: <g:Label ui:field="message" addStyleNames="{style.errorMessageLabel}" /> -- To view, visit https://gerrit.ovirt.org/38329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4bed1019f94064b9800fda0fb17a6def46ab221 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
