Allon Mureinik has posted comments on this change. Change subject: engine, webadmin: Allow to specify disk error_policy in Web UI ......................................................................
Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/38329/4/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml File frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml: Line 36: <include name="common/businessentities/DiskImage.java" /> Line 37: <include name="common/businessentities/DiskImageBase.java" /> Line 38: <include name="common/businessentities/DiskImageDynamic.java" /> Line 39: <include name="common/businessentities/DiskInterface.java" /> Line 40: <include name="common/businessentities/DiskErrorPolicy.java" /> Should probably be indented like the other lines Line 41: <include name="common/businessentities/DiskType.java" /> Line 42: <include name="common/businessentities/DisplayType.java" /> Line 43: <include name="common/businessentities/GraphicsDevice.java" /> Line 44: <include name="common/businessentities/GraphicsType.java" /> -- To view, visit https://gerrit.ovirt.org/38329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4bed1019f94064b9800fda0fb17a6def46ab221 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
