Alon Bar-Lev has posted comments on this change. Change subject: hosted-engine: WIP - allow to deploy hosted-engine ......................................................................
Patch Set 3: (9 comments) https://gerrit.ovirt.org/#/c/38547/3/src/ovirt_host_deploy/constants.py File src/ovirt_host_deploy/constants.py: Line 45: LIBVIRT_DEFAULT_TRUST_STORE = '/etc/pki/libvirt' Line 46: LIBVIRT_DEFAULT_CLIENT_CA_FILE = '../CA/cacert.pem' Line 47: LIBVIRT_DEFAULT_CLIENT_CERT_FILE = 'clientcert.pem' Line 48: LIBVIRT_DEFAULT_CLIENT_KEY_FILE = 'private/clientkey.pem' Line 49: LIBVIRT_QEMU_CONF = '/etc/libvirt/qemu.conf' vdsm is aware of hosted engine, why can't it set libvirt settings at runtime? if not vdsm the service of hosted. we should not touch these files if we can avoid. if there are other alternative please specify so we can find the best solution. Line 50: Line 51: VDSM_DATA_DIR = '/usr/share/vdsm' Line 52: Line 53: HOOKS_DIR = '/usr/libexec/vdsm/hooks' Line 142: Line 143: Line 144: @util.export Line 145: @util.codegen Line 146: class HostedEngineEnv(object): please use NEUTRON_OPENVSWITCH_CONFIG_PREFIX like configuration setting. Line 147: ENABLE = 'HOSTED_ENGINE/enable' Line 148: CONNECTION_UUID = 'HOSTED_ENGINE/connectionUUID' Line 149: CONSOLE_TYPE = 'HOSTED_ENGINE/consoleType' Line 150: DOMAIN_TYPE = 'HOSTED_ENGINE/domainType' https://gerrit.ovirt.org/#/c/38547/3/src/plugins/ovirt-host-deploy/hosted-engine/configureha.py File src/plugins/ovirt-host-deploy/hosted-engine/configureha.py: Line 72: odeploycons.HostedEngineEnv.STORAGE_DOMAIN_CONNECTION, Line 73: odeploycons.HostedEngineEnv.USE_SSL, Line 74: odeploycons.HostedEngineEnv.VM_UUID, Line 75: ): Line 76: self.environment.setdefault(env, '') None is for unset Line 77: Line 78: @plugin.event( Line 79: stage=plugin.Stages.STAGE_PROGRAMS, Line 80: ) Line 146: self.logger.info(_('Updating hosted-engine configuration')) Line 147: conf = { Line 148: 'bridge': self.environment[ Line 149: odeploycons.VdsmEnv.MANAGEMENT_BRIDGE_NAME Line 150: ], this won't be set Line 151: 'ca_cert': os.path.join( Line 152: odeploycons.FileLocations.VDSM_TRUST_STORE, Line 153: odeploycons.FileLocations.VDSM_SPICE_CA_FILE Line 154: ), Line 149: odeploycons.VdsmEnv.MANAGEMENT_BRIDGE_NAME Line 150: ], Line 151: 'ca_cert': os.path.join( Line 152: odeploycons.FileLocations.VDSM_TRUST_STORE, Line 153: odeploycons.FileLocations.VDSM_SPICE_CA_FILE why spice? Line 154: ), Line 155: 'ca_subject': '"{subject}"'.format( Line 156: subject=self.environment[ Line 157: odeploycons.HostedEngineEnv.SPICE_SUBJECT Line 154: ), Line 155: 'ca_subject': '"{subject}"'.format( Line 156: subject=self.environment[ Line 157: odeploycons.HostedEngineEnv.SPICE_SUBJECT Line 158: ], why do you care what ca subject is? Line 159: ), # TODO: check if it's already passed for VDSM configuration Line 160: 'connectionUUID': self.environment[ Line 161: odeploycons.HostedEngineEnv.CONNECTION_UUID Line 162: ], Line 201: ], Line 202: 'sdUUID': self.environment[ Line 203: odeploycons.HostedEngineEnv.SD_UUID Line 204: ], Line 205: 'service_start_time': odeploycons.Const.HOSTED_ENGINE_START_TIME, so you overwrite your own configuration each time you start?!?! Line 206: 'spUUID': self.environment[ Line 207: odeploycons.HostedEngineEnv.SP_UUID Line 208: ], Line 209: 'storage': self.environment[ Line 246: self.logger.info(_('Enabling and starting HA services')) Line 247: for service in ( Line 248: odeploycons.Const.HA_AGENT_SERVICE, Line 249: odeploycons.Const.HA_BROCKER_SERVICE, Line 250: ): this should be in packages Line 251: self.services.startup( Line 252: name=service, Line 253: state=True, Line 254: ) Line 254: ) Line 255: self.services.state( Line 256: name=service, Line 257: state=True, Line 258: ) you should probably restart to apply new configuration Line 259: Line 260: -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
