Sandro Bonazzola has posted comments on this change. Change subject: hosted-engine: WIP - allow to deploy hosted-engine ......................................................................
Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/38547/3/src/ovirt_host_deploy/constants.py File src/ovirt_host_deploy/constants.py: Line 142: Line 143: Line 144: @util.export Line 145: @util.codegen Line 146: class HostedEngineEnv(object): > please use NEUTRON_OPENVSWITCH_CONFIG_PREFIX like configuration setting. Done Line 147: ENABLE = 'HOSTED_ENGINE/enable' Line 148: CONNECTION_UUID = 'HOSTED_ENGINE/connectionUUID' Line 149: CONSOLE_TYPE = 'HOSTED_ENGINE/consoleType' Line 150: DOMAIN_TYPE = 'HOSTED_ENGINE/domainType' https://gerrit.ovirt.org/#/c/38547/3/src/plugins/ovirt-host-deploy/hosted-engine/configureha.py File src/plugins/ovirt-host-deploy/hosted-engine/configureha.py: Line 146: self.logger.info(_('Updating hosted-engine configuration')) Line 147: conf = { Line 148: 'bridge': self.environment[ Line 149: odeploycons.VdsmEnv.MANAGEMENT_BRIDGE_NAME Line 150: ], > no need to add new env, use the prefix and you will be able to set the enti Done Line 151: 'ca_cert': os.path.join( Line 152: odeploycons.FileLocations.VDSM_TRUST_STORE, Line 153: odeploycons.FileLocations.VDSM_SPICE_CA_FILE Line 154: ), Line 154: ), Line 155: 'ca_subject': '"{subject}"'.format( Line 156: subject=self.environment[ Line 157: odeploycons.HostedEngineEnv.SPICE_SUBJECT Line 158: ], > this is not ca subject, it is the end certificate subject? not sure why it yes, we currently depends on remote-viewer. It was required in product specs. Line 159: ), # TODO: check if it's already passed for VDSM configuration Line 160: 'connectionUUID': self.environment[ Line 161: odeploycons.HostedEngineEnv.CONNECTION_UUID Line 162: ], Line 254: ) Line 255: self.services.state( Line 256: name=service, Line 257: state=True, Line 258: ) > you should probably restart to apply new configuration Done Line 259: Line 260: -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
