Martin Sivák has posted comments on this change. Change subject: hosted-engine: WIP - allow to deploy hosted-engine ......................................................................
Patch Set 3: (1 comment) It looks reasonable with regards to hosted engine logic. Btw why do we force type 4 UUIDs? Any valid UUID should work fine.. or not? https://gerrit.ovirt.org/#/c/38547/3/src/plugins/ovirt-host-deploy/hosted-engine/configureqemu.py File src/plugins/ovirt-host-deploy/hosted-engine/configureqemu.py: Line 61: old_content = f.read().splitlines() Line 62: new_content = [] Line 63: new_conf = 'lock_manager="sanlock"' Line 64: found = False Line 65: for line in old_content: I would expect a comment here explaining what this part does. Line 66: match = self.RE_LOCK_MANAGER.match(line) Line 67: if match: Line 68: found = True Line 69: self.logger.debug( -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
