Maor Lipchuk has posted comments on this change. Change subject: core: fix of job messages that uses SnapshotName object (#844283) ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcObjectType.java Line 27: Quota(17, "Quota"), Line 28: GlusterVolume(18, "Gluster Volume"), Line 29: Disk(19, "Disk"), Line 30: VmInterface(20, "VmInterface"), Line 31: SnapshotName(20, "SnapshotName"); 1. code 20 is already in use 2. Please change vdc object type to be snapshot and not snapshot name Line 32: Line 33: private int value; Line 34: private String vdcObjectTranslationVal; Line 35: private static final Map<Integer, VdcObjectType> map = new HashMap<Integer, VdcObjectType>(values().length); -- To view, visit http://gerrit.ovirt.org/7745 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43e1de508e53eaf624fd7fb3de455a80003c5cd6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
