Allon Mureinik has posted comments on this change.
Change subject: core: fix of job messages that uses SnapshotName object
(#844283)
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
Looks ok, except for a redundent tab I believe you introduced by mistake (see
inline).
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
Line 56: }
Line 57:
Line 58: /**
Line 59: * @return The image snapshots associated with the VM snapshot.
Line 60: * Note that the first time this method is run it issues
DAO call.
I think this tab is by mistake.
Line 61: */
Line 62: protected List<DiskImage> getSourceImages() {
Line 63: if (_sourceImages == null) {
Line 64: _sourceImages =
getDiskImageDAO().getAllSnapshotsForVmSnapshot(getParameters().getSnapshotId());
--
To view, visit http://gerrit.ovirt.org/7745
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1de508e53eaf624fd7fb3de455a80003c5cd6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
