Allon Mureinik has posted comments on this change.
Change subject: core: fix of job messages that uses SnapshotName object
(#844283)
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
Line 55: return jobProperties;
Line 56: }
Line 57:
Line 58: /**
Line 59: * @return The image snapshots associated with the VM snapshot.
Note that the first time this method is run it
why is this format change related to the patch?
Line 60: * issues DAO call.
Line 61: */
Line 62: protected List<DiskImage> getSourceImages() {
Line 63: if (_sourceImages == null) {
Line 196: return
validate(createSnapshotValidator().snapshotExists(getVmId(),
getParameters().getSnapshotId()));
Line 197: }
Line 198:
Line 199: // TODO: this is a temporary method used until
ImagesHandler.PerformImagesChecks will get decoupeld to several tests
Line 200: // Until then, this method is called and passes hasImages()
onwards so the VM validations are done even for diskless
here too
Line 201: // VMs
Line 202: protected boolean validateImagesAndVMStates() {
Line 203: return ImagesHandler.PerformImagesChecks(getVm(),
getReturnValue().getCanDoActionMessages(),
Line 204: getVm().getstorage_pool_id(), Guid.Empty,
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcObjectType.java
Line 27: Quota(17, "Quota"),
Line 28: GlusterVolume(18, "Gluster Volume"),
Line 29: Disk(19, "Disk"),
Line 30: VmInterface(20, "VmInterface"),
Line 31: SnapshotName(21, "SnapshotName");
All the other objects are actual objects in the system.
Why do anything different for snapshots?
Line 32:
Line 33: private int value;
Line 34: private String vdcObjectTranslationVal;
Line 35: private static final Map<Integer, VdcObjectType> map = new
HashMap<Integer, VdcObjectType>(values().length);
--
To view, visit http://gerrit.ovirt.org/7745
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1de508e53eaf624fd7fb3de455a80003c5cd6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
