Sandro Bonazzola has posted comments on this change. Change subject: hosted-engine: allow to deploy hosted-engine ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/38547/10/src/plugins/ovirt-host-deploy/hosted-engine/configureqemu.py File src/plugins/ovirt-host-deploy/hosted-engine/configureqemu.py: Line 57: """ Line 58: Changes the lock manager from lockd (default) to sanlock. Line 59: Hosted Engine HA relies on sanlock locking for avoiding to launch Line 60: the Hosted Engine VM on different hosts at the same time. Line 61: """ > we left with this, the ha should dynamically set libvirt if possible, or we It's already done by vdsm: ## beginning of configuration section by vdsm-4.13.0 auto_dump_path="/var/log/core" dynamic_ownership=0 lock_manager="sanlock" remote_display_port_max=6923 remote_display_port_min=5900 save_image_format="lzop" spice_tls=1 spice_tls_x509_cert_dir="/etc/pki/vdsm/libvirt-spice" ## end of configuration section by vdsm-4.13.0 dropping this configuration from here, letting vdsm to do that. Line 62: self.logger.info(_('Configuring libvirt')) Line 63: old_content = [] Line 64: if os.path.exists(odeploycons.FileLocations.LIBVIRT_QEMU_CONF): Line 65: with open(odeploycons.FileLocations.LIBVIRT_QEMU_CONF, 'r') as f: -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
