David Caro has posted comments on this change. Change subject: reorg repoclosure script for ease of maintenance ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/39249/5/jobs/packaging/repo_closure_check.sh File jobs/packaging/repo_closure_check.sh: Line 29: echo "FATAL: ${msg}" Line 30: if [[ ${TEST_RUN} -eq 0 ]]; then Line 31: # This is not test, so do exit Line 32: exit 1 Line 33: fi I really think you should do check the return code (see run bats command). And not need this env var Line 34: } Line 35: Line 36: usage() { Line 37: cat << __EOF__ -- To view, visit https://gerrit.ovirt.org/39249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I207c5c59ca3149c17897c231e391e15e7eec4363 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Max Kovgan <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Max Kovgan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
