Sandro Bonazzola has posted comments on this change. Change subject: reorg repoclosure script for ease of maintenance ......................................................................
Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/39249/6/jobs/packaging/repo_closure_check.sh File jobs/packaging/repo_closure_check.sh: Line 188: prefix="tmpyumconfdir" Line 189: yumconfdir="${1}" Line 190: if [[ -z "${yumconfdir}" ]]; then Line 191: yumconfdir="$( mktemp -d ${prefix}.XXXXXXXX )" Line 192: add_on_exit "rm -fr \"${yumconfdir}\"" please use spaces Line 193: fi Line 194: conffile="${yumconfdir}/yum.conf" Line 195: logfile="${yumconfdir}/yum.log" Line 196: reposdir="${yumconfdir}/yum.repos.d" Line 252: conffile \ Line 253: rpath Line 254: delim="${1:-,}" Line 255: repos=( "${@:2}" ) Line 256: yumconfdir=$( gen_yum_conf "${delim}" ) looks like gen_yum_conf expect yumconfdir as $1. I think "${delim}" here is wrong. Line 257: conffile=${yumconfdir}/yum.conf Line 258: rpath=${yumconfdir}/yum.repos.d/repos.repo Line 259: append_repos_to_rpath ${delim} ${rpath} ${repos[@]} Line 260: echo ${conffile} Line 407: Line 408: case ${DISTRIBUTION} in Line 409: el|Centos) Line 410: # TODO: extract these into files? Line 411: repos+=( > Looks like += works only on bash 3. it doesn't work with bash 4.2.53 ( fedo ignore :-/ Line 412: "check-custom-${distid},baseurl,${CUSTOM_URL}" Line 413: "check-base-${distid},baseurl,${CENTOS_MIRROR}/${distro_ver}/os/x86_64/" Line 414: "check-updates-${distid},baseurl,${CENTOS_MIRROR}/${distro_ver}/updates/x86_64/" Line 415: "check-extras-${distid},baseurl,${CENTOS_MIRROR}/${distro_ver}/extras/x86_64/" -- To view, visit https://gerrit.ovirt.org/39249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I207c5c59ca3149c17897c231e391e15e7eec4363 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Max Kovgan <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Max Kovgan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
