David Caro has posted comments on this change. Change subject: reorg repoclosure script for ease of maintenance ......................................................................
Patch Set 6: (14 comments) Mostly I'm (re)writing down the bash guide for clearance (I accept idas/discussions/) at https://gerrit.ovirt.org/#/c/39490/ https://gerrit.ovirt.org/#/c/39249/6/jobs/packaging/repo_closure_check.sh File jobs/packaging/repo_closure_check.sh: Line 176: # Line 177: # params: Line 178: # $1 - yumconfdir - directory for yum.conf Line 179: # returns: Line 180: # yumconfdir please document that it generates it if not passed Line 181: local \ Line 182: yumconfdir \ Line 183: conffile \ Line 184: logfile \ Line 259: ${delim} ${rpath} ${repos[@]} quotes Line 278: ${repos[@]} quotes Line 279: ${delim} ${repo} quotes Line 280: ${repo_data[0]} quotes Line 296: [ "${DISTRIBUTION}" = "el" ] [[ ]] Line 298: [ "${DISTRIBUTION}" = "fc" ] [[ ]] Line 454: $( make_yum_config "," "${repos[@]}" ) quotes Line 455: $( dirname "${yum_config}" ) quotes Line 456: $( gen_lookaside_repos_list "," "${repos[@]:1}" ) quotes Line 457: $( repo_data_to_arr "," ${repos[0]} ) quotes Line 458: repoclosure --tempcache --conf "${yum_config}" \ : "${look_aside}" -r "${check_repo}" split by option: command \ -r something \ param \ param Line 460: indent at the same depth as previous command: command1 \ -a option \ || command 2 Line 470: # check_repo_closure Line 471: check_repo_closure_new "${DISTRIBUTION}" "${DISTRIBUTION_VERSION}" Line 472: } Line 473: Line 474: if [[ ${TEST_RUN} -eq 0 ]]; then Instead of this, check if $0 ends with /bash (that means it has been sourced) Line 475: # only runs when TEST_RUN is 0. Line 476: main "${@}" Line 477: exit $? -- To view, visit https://gerrit.ovirt.org/39249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I207c5c59ca3149c17897c231e391e15e7eec4363 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Max Kovgan <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Max Kovgan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
