Moti Asayag has posted comments on this change. Change subject: events: VM Status based on an event ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/37488/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RefresherFactory.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RefresherFactory.java: Line 8: // TODO Use CDI to inject it Line 9: public class RefresherFactory { Line 10: Line 11: public static VMStatsRefresher create(final VdsManager manager, final AuditLogDirector auditLogDirector) { Line 12: if (FeatureSupported.vmStatsEvents(manager.getComatibilityVersion())) { shouldn't you check the protocol is Json and not XmlRpc in this context ? or don't we expect XmlRpc at this time or can we support notifications even if the chosen protocol is XmlRpc ? Line 13: return new EventVMStatsRefresher(manager, auditLogDirector); Line 14: } Line 15: return new PollVMStatsRefresher(manager, auditLogDirector); Line 16: } https://gerrit.ovirt.org/#/c/37488/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java: Line 42: Line 43: @Override Line 44: public void startMonitoring() { Line 45: super.startMonitoring(); Line 46: this.resourceManager.subscribe(new EventSubscriber(manager.getVdsHostname() + "|*|VM_status|*") { is the manager.getVdsHostname() used for registering the host for its own messages ? Where can i found the hostname being added to the request from vdsm side ? : https://gerrit.ovirt.org/#/c/38937/1/vdsm/virt/vm.py notification = self.cif.create_notification( '|virt|VM_status|' + self.id ) notification.emit(**{self.id: value}) Line 47: Line 48: @Override Line 49: public void onSubscribe(Subscription sub) { Line 50: subscription = sub; -- To view, visit https://gerrit.ovirt.org/37488 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5b35877ccd63372759ad6989280e9417c259b21 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
